Skip to content

Conversation

@davidsnam-intel
Copy link
Contributor

@davidsnam-intel davidsnam-intel commented Oct 13, 2025

Details:

  • Prevent buffer share for onednn concatenation.

Issues:

  • onednn concatenation doesn't support non-zero padding which can occur for unaligned feature.
  • To support this case, onednn concatenation node shouldn't share the memory.

Graphs:

image

Checklist:

  • Is it a proper fix? (Not a workaround)
  • Did you include test case for this fix, if necessary?
  • Did you review existing test that can be extended to cover this scenario?

Tickets:

  • 172243

@davidsnam-intel davidsnam-intel requested review from a team as code owners October 13, 2025 15:56
@github-actions github-actions bot added the category: GPU OpenVINO GPU plugin label Oct 13, 2025
@davidsnam-intel davidsnam-intel force-pushed the david/fix-concat-onednn branch 2 times, most recently from fb59806 to 9853533 Compare October 15, 2025 08:52
@p-durandin p-durandin added this to the 2025.4 milestone Oct 16, 2025
@isanghao
Copy link
Contributor

no issue from dgpu daily test

@yeonbok yeonbok added this pull request to the merge queue Oct 21, 2025
Merged via the queue into openvinotoolkit:master with commit 4890db5 Oct 21, 2025
187 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Nov 4, 2025
### Details:
- Performance degradation in `flux.1-schnell` caused by
[PR#32386](#32386).
- Resolved by not using onednn when feature isn't aligned for
concatenation.
IamRam3 pushed a commit to IamRam3/openvino that referenced this pull request Nov 6, 2025
…32612)

### Details:
- Performance degradation in `flux.1-schnell` caused by
[PR#32386](openvinotoolkit#32386).
- Resolved by not using onednn when feature isn't aligned for
concatenation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: GPU OpenVINO GPU plugin Code Freeze

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants